Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Journal index offset 8bytes #7836

Merged
merged 2 commits into from
May 8, 2024
Merged

Journal index offset 8bytes #7836

merged 2 commits into from
May 8, 2024

Conversation

max-hoffman
Copy link
Contributor

On >10GB datasets, offsets overflow uint32. Bug from previous PR #7780

reltuk
reltuk approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@max-hoffman max-hoffman merged commit 1488284 into main May 8, 2024
19 of 20 checks passed
@max-hoffman max-hoffman deleted the max/journal-index-offset-8bytes branch May 8, 2024 22:29
@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ea37814 ok 5937457
version total_tests
ea37814 5937457
correctness_percentage
100.0

@BrewTestBot BrewTestBot mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@max-hoffman @coffeegoddd @reltuk