Naked deletes now just delete everything instead of iterating #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, darn it Zach but an empty map was causing a panic lol |
zachmu
approved these changes
Sep 17, 2019
go/cmd/dolt/commands/sql.go
Outdated
| return nil, false | ||
| } | ||
| // This is so the results are displayed as expected | ||
| if _, sqlSch, rowIter, err := sqlNewEngine(fmt.Sprintf("select COUNT(*) as updated from `%v`", tName), root); err == nil { |
There was a problem hiding this comment.
This is going to be expensive -- it loads the entire table of data just to count it. You should get the number of rows by calling .size() or similar on the table map
Hydrocharged
force-pushed
the
daylon/sql-special
branch
from
6e80c26
to
c987250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mean this works but it's ugly and I'm not sure of a better way to do it really