dolt table import -r #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbantle22
force-pushed
the
taylor/table-import-replace
branch
from
db09aa5
to
170e168
Compare
tbantle22
force-pushed
the
taylor/table-import-replace
branch
2 times, most recently
from
ba00761
to
10aacb1
Compare
bheni
requested changes
Sep 20, 2019
tbantle22
commented
Sep 20, 2019
| @@ -77,8 +77,13 @@ func NewJSONReader(nbf *types.NomsBinFormat, r io.ReadCloser, info *JSONFileInfo | |||
| return nil, err | |||
| } | |||
|
|
|||
| ableToDecode := true | |||
There was a problem hiding this comment.
It was tricky to verify the schema for JSON because either a schema file is required or the schema from the existing table is used. When decoding the JSON rows here, an error is returned if the rows don't match the existing schema. This was not being handled before so I added an AbleToDecode property to JSONFileInfo that tracks whether the rows were decoded or not and can be used in the VerifySchema method. Let me know if you think there's a better way to do this - I couldn't directly compare the schemas here like I could for CSV and XLSX files.
tbantle22
force-pushed
the
taylor/table-import-replace
branch
from
f78e463
to
8afef26
Compare
tbantle22
commented
Sep 20, 2019
tbantle22
force-pushed
the
taylor/table-import-replace
branch
from
8afef26
to
93dd368
Compare
bheni
approved these changes
Sep 21, 2019
tbantle22
force-pushed
the
taylor/table-import-replace
branch
from
d5971d4
to
59536a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Replaces existing table with the contents of the file while preserving the original schema