{go, bats}: Replace table works with file with schema in different order #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bheni can we merge this? It's blocking me testing my import script fully. |
bheni
approved these changes
Sep 24, 2019
| @@ -95,10 +95,10 @@ func VerifyInSchema(inSch, outSch Schema) (bool, error) { | |||
| } | |||
|
|
|||
| match := true | |||
| err := outSchCols.Iter(func(tag uint64, outCol Column) (stop bool, err error) { | |||
| inCol, ok := inSchCols.GetByTag(tag) | |||
| err := inSchCols.Iter(func(tag uint64, inCol Column) (stop bool, err error) { | |||
There was a problem hiding this comment.
Maybe just update the comment to tell how the comparison is being done now, but LGTM.
There was a problem hiding this comment.
…der and added bats tests
tbantle22
force-pushed
the
taylor/csv-tag-fix
branch
2 times, most recently
from
2365ab2
to
1c4bb87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.