Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use tr to lowercase output instead of {output,,} #909

Merged
merged 2 commits into from Oct 3, 2020
Merged

use tr to lowercase output instead of {output,,} #909

merged 2 commits into from Oct 3, 2020

Conversation

andy-wm-arthur
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur commented Oct 2, 2020 •
edited

lowercasing via parameter expansion ${output,,} is only supported on Bash 4+. I switched to using tr so I could run the tests locally.

@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review October 2, 2020 21:38
Hydrocharged
Hydrocharged approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@andy-wm-arthur andy-wm-arthur merged commit fd5dcab into master Oct 3, 2020
@Hydrocharged Hydrocharged deleted the andy/fix-compat-runner branch November 11, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy-wm-arthur @Hydrocharged