Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maxiumum SQL statement length to 100MB (initially 512K) #917

Merged
merged 1 commit into from Oct 13, 2020

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Oct 8, 2020

Signed-off-by: Zach Musgrave zach@liquidata.co

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2020

CLA assistant check
All committers have signed the CLA.

@zachmu zachmu requested a review from reltuk October 8, 2020 21:43
Signed-off-by: Zach Musgrave <zach@dolthub.com>
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@timsehn
Copy link
Sponsor Contributor

timsehn commented Oct 12, 2020

Should we have a bats test w/ a really long statement? Maybe not 500Mb but a 1MB might be cool.

@zachmu
Copy link
Member Author

zachmu commented Oct 13, 2020

@timsehn I can do that as a followup, gonna get this merged in the meantime

@zachmu zachmu merged commit 8d92e05 into master Oct 13, 2020
@Hydrocharged Hydrocharged deleted the zachmu/scan-buffer branch November 11, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants