Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bh/output updates #98

Merged
merged 6 commits into from
Oct 1, 2019
Merged

Bh/output updates #98

merged 6 commits into from
Oct 1, 2019

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Sep 30, 2019

No description provided.

@bheni bheni requested a review from zachmu September 30, 2019 23:36
zachmu
zachmu approved these changes Sep 30, 2019
View reviewed changes
go/libraries/doltcore/mvdata/data_mover.go Outdated
@@ -169,17 +170,19 @@ func NewDataMover(ctx context.Context, root *doltdb.RootValue, fs filesys.Filesy
return imp, nil
}

func (imp *DataMover) Move(ctx context.Context) error {
func (imp *DataMover) Move(ctx context.Context) (int64, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should document the new return param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

go/libraries/doltcore/remotestorage/chunk_store.go
@@ -230,8 +230,8 @@ func (dcs *DoltChunkStore) GetManyCompressed(ctx context.Context, hashes hash.Ha
}

const (
getLocsBatchSize = 4096
getLocsMaxConcurrency = 32
getLocsBatchSize = 128 * 1024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file unrelated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. Pullin a sneaky.

@bheni bheni merged commit 27412b3 into master Oct 1, 2019
@bheni bheni deleted the bh/output-updates branch October 1, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bheni @zachmu