Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication POC and tests #129

Merged
merged 49 commits into from
Feb 16, 2024
Merged

replication POC and tests #129

merged 49 commits into from
Feb 16, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Feb 15, 2024

Looking for feedback on this approach before polishing it off for submission.

Missing / next steps:

  1. Keyless table tests
  2. Start up postgres during CI so the replication tests can run correctly there
  3. UX to configure and start up replication for the server

@zachmu
Checkpoint for replication code
c461a9c
@zachmu
More complete testing setup
c9702a2
@zachmu
Updated events api
be058eb
@zachmu
Fix NPE
8fc38c2
@zachmu
Bug fixes
8a74bda
@zachmu
More testing of re-connect, still not working exactly correctly. Fill…
be8271c 
…ing in query reconstruction for insert, delete, update
@zachmu
Better literal quoting
28fd3b5
@zachmu
Better update handling
716173d
@zachmu
Better delete
5c84784
@zachmu
Actually replicating queries
14e4ec4
@zachmu
Got rid of limited listener, no longer actually used
943fed6
@zachmu
Support for public schema
9021563
@zachmu
First fully working end to end test
b1256fb
@zachmu
More tests, transaction framework
35e1fa6
@zachmu
Replication stop method, not quite working
45510ae
@zachmu
Better shutdown logic
2c68506
@zachmu
Better shutdown logic
b01a024
@zachmu
Full (simple) concurrency test
c75e742
@zachmu
Merge main
0e4d57e
@zachmu
Re-add pgloglrepl
b622de1
@zachmu
UUID test
03739eb
@zachmu
Formatting
e41feb5
Hydrocharged
Hydrocharged approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction looks good to me! It's just nitpicks and comments making sure I understand what's going on here, but looks good besides that.

.github/workflows/test.yml Outdated Show resolved Hide resolved
testing/go/framework.go Outdated Show resolved Hide resolved
server/logrepl/replication.go Outdated Show resolved Hide resolved
server/logrepl/replication.go Show resolved Hide resolved
server/logrepl/replication.go Outdated Show resolved Hide resolved
server/logrepl/replication.go Show resolved Hide resolved
server/logrepl/replication.go Show resolved Hide resolved
testing/go/replication_test.go Show resolved Hide resolved
testing/go/replication_test.go Outdated Show resolved Hide resolved
testing/go/replication_test.go Outdated Show resolved Hide resolved
@zachmu zachmu merged commit d1053be into main Feb 16, 2024
7 checks passed
@zachmu zachmu deleted the zachmu/replication branch February 16, 2024 19:02
@BrewTestBot BrewTestBot mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zachmu @Hydrocharged