-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function Overload Rework #133
Conversation
Build currently fails as I need to finish converting all of the functions over to the new framework. Also need to add more types. Neither of those will take long. However, I'm still trying to find a good way to represent type conversions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's here looks fine, just some comments about the organization. Approving without passing tests assuming that changes will be minor, ping me if that's not the case
ee2b6e4
to
de0f152
Compare
The replication tests will fail, but for the most part this is reviewable. |
6136021
to
9584086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My main comment about this is that we need engine (server) tests for all the functions you defined. Make that a fast-follow to this.
9584086
to
eaf588e
Compare
eaf588e
to
6b2e975
Compare
What this adds:
The previous function overload framework only worked in a very limited capacity. This PR intends to remove those limitations, allowing for all current (and future) Postgres functions to be defined. In general, this is also designed to support user-defined functionality, or at least designed in such a way that it will be relatively easy to fully implement it later on.
Related PR: dolthub/dolt#7537