Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parsing ALTER INDEX stmt #135

Merged
merged 16 commits into from
Feb 23, 2024
Merged

support parsing ALTER INDEX stmt #135

merged 16 commits into from
Feb 23, 2024

Conversation

jennifersp
Copy link
Contributor

This PR also fixes all the synopsis that had [ $argmode$ ] [ $argname$ ] $argtype$ [ , ... ] to correct format of { [ $argmode$ ] [ $argname$ ] $argtype$ } [ , ... ]. The tests that are affected by this change is updated.

@jennifersp jennifersp changed the base branch from main to jennifer/create-table February 22, 2024 23:44
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only comment here is that I'd only generate new tests for the statements that were modified, like in your previous PRs.

Base automatically changed from jennifer/create-table to main February 22, 2024 23:57
@jennifersp jennifersp merged commit 7dff715 into main Feb 23, 2024
8 checks passed
@jennifersp jennifersp deleted the jennifer/alter-index branch February 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants