Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support PROCEDURE statements syntax parsing #136

Merged
merged 17 commits into from
Feb 23, 2024
Merged

support PROCEDURE statements syntax parsing #136

merged 17 commits into from
Feb 23, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Feb 21, 2024 •
edited
Loading

This PR includes syntax parsing support for:

  • CREATE PROCEDURE
  • DROP PROCEDURE
  • ALTER PROCEDURE
  • ALTER FUNCTION

@jennifersp jennifersp changed the base branch from main to jennifer/alter-index February 22, 2024 23:45
Hydrocharged
Hydrocharged approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few comments

postgres/parser/parser/sql.y Show resolved Hide resolved
postgres/parser/sem/tree/create_procedure.go Outdated Show resolved Hide resolved
Base automatically changed from jennifer/alter-index to main February 23, 2024 00:23
@jennifersp jennifersp enabled auto-merge (squash) February 23, 2024 01:04
@jennifersp jennifersp merged commit b1e0366 into main Feb 23, 2024
8 checks passed
@jennifersp jennifersp deleted the jennifer/procedure branch February 23, 2024 01:05
@BrewTestBot BrewTestBot mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jennifersp @Hydrocharged