Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unary and binary operator functions #147

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Hydrocharged
Copy link
Collaborator

This adds all of the internal functions for unary and binary operators (for types that are currently implemented).

@Hydrocharged Hydrocharged force-pushed the daylon/unary-binary-functions branch 4 times, most recently from c628514 to 3118dab Compare March 25, 2024 12:05
@Hydrocharged Hydrocharged marked this pull request as ready for review March 25, 2024 21:42
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not too much to say

server/functions/binary/bit_and.go Show resolved Hide resolved
server/functions/unary/plus.go Show resolved Hide resolved
testing/go/framework.go Show resolved Hide resolved
testing/go/operators_test.go Show resolved Hide resolved
@Hydrocharged
Copy link
Collaborator Author

Enabling the function tests. They were mostly failing due to missing operator functions. I'm adding them to this PR since they're all just changes to conform to the failing tests.

@Hydrocharged Hydrocharged merged commit e0671d0 into main Mar 26, 2024
8 checks passed
@Hydrocharged Hydrocharged deleted the daylon/unary-binary-functions branch March 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants