Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Array Types #162

Merged
merged 2 commits into from
Apr 4, 2024
Merged

All Array Types #162

merged 2 commits into from
Apr 4, 2024

Conversation

Hydrocharged
Copy link
Collaborator

This PR adds array types for all existing types. This is done by providing a wrapper that handles all of the array-functionality over the base type. In addition, this removes the mock array functionality that only worked to demonstrate the viability of boolean[], replacing the functionality with fully working equivalents.

@Hydrocharged Hydrocharged requested a review from zachmu April 1, 2024 10:55
@Hydrocharged Hydrocharged force-pushed the daylon/array branch 2 times, most recently from 0fbeda9 to 305e5d3 Compare April 3, 2024 13:43
@Hydrocharged Hydrocharged marked this pull request as ready for review April 3, 2024 13:43
@Hydrocharged Hydrocharged changed the title [DRAFT] All Array Types All Array Types Apr 3, 2024
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is very cool. Only major comment is the serialization method for these values.

server/expression/array.go Outdated Show resolved Hide resolved
server/expression/literal.go Outdated Show resolved Hide resolved
server/types/array.go Show resolved Hide resolved
server/types/array.go Show resolved Hide resolved
server/types/array.go Show resolved Hide resolved
server/types/varchar_array.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 5c63877 into main Apr 4, 2024
8 checks passed
@Hydrocharged Hydrocharged deleted the daylon/array branch April 4, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants