Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting doltgres server creates db in defined directory #83

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Dec 27, 2023

Currently, doltgres uses dolt init when starting doltgres server with data dir set to empty directory. When there is no dolt or doltgres config user.name and user.email, it fails to create a new database with error message from dolt init, which suggests to set dolt user info. Current fix will not return error; instead, it will use user name, postgres and email, postgres@somewhere.com if it's not set.

@jennifersp jennifersp linked an issue Dec 27, 2023 that may be closed by this pull request
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple comments

server/server.go Outdated Show resolved Hide resolved
testing/bats/doltgres.bats Show resolved Hide resolved
testing/bats/doltgres.bats Show resolved Hide resolved
@jennifersp jennifersp merged commit a444d36 into main Dec 28, 2023
7 checks passed
@jennifersp jennifersp deleted the jennifer/empty-dir branch December 28, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot run doltgres with data dir set to empty directory
2 participants