Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andy/div by zero #108

Merged
merged 4 commits into from May 19, 2020
Merged

Andy/div by zero #108

merged 4 commits into from May 19, 2020

Conversation

andy-wm-arthur
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur commented May 19, 2020 •
edited

This fixes a panic for select 1/0 from dual

MySQL also errors on divide by zero in at least some configs

I can change this to return NULL if that's preferable.

@andy-wm-arthur
fixed divide by zero
388f917 
Signed-off-by: Andy Arthur <andy@liquidata.co>
@andy-wm-arthur
improving error msg
8f83ca2 
Signed-off-by: Andy Arthur <andy@liquidata.co>
@andy-wm-arthur andy-wm-arthur mentioned this pull request May 19, 2020
Merged
@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review May 19, 2020 19:44
zachmu
zachmu reviewed May 19, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should follow the default mysql 8.0 behavior, which is to evaluate to NULL.

Also please add an engine test.

@andy-wm-arthur
changed error to NULL value
b7e795a 
Signed-off-by: Andy Arthur <andy@liquidata.co>
@andy-wm-arthur
Copy link
Contributor Author

👌

@andy-wm-arthur
added engine test for 1.0/0.0
bc7b5f4 
Signed-off-by: Andy Arthur <andy@liquidata.co>
@andy-wm-arthur andy-wm-arthur merged commit 9d24532 into master May 19, 2020
zachmu
zachmu reviewed May 19, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should follow up to make the behavior the same for floats and ints.

engine_test.go
[]sql.Row{{sql.Null}},
},
{ "SELECT 1.0/0.0 FROM dual",
[]sql.Row{{float64(math.Inf(1))}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be null too. Floats and ints should have the same behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy-wm-arthur @zachmu