Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed character sets and collations to use integer IDs #1090

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Changed character sets and collations to use integer IDs #1090

merged 1 commit into from
Jul 1, 2022

Conversation

Hydrocharged
Copy link
Contributor

No description provided.

@Hydrocharged Hydrocharged requested a review from zachmu June 30, 2022 10:28
zachmu
zachmu approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some comments about documenting these

sql/collations.go Outdated Show resolved Hide resolved
sql/collations.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit fb7707b into main Jul 1, 2022
@Hydrocharged Hydrocharged deleted the daylon/string-collation branch July 1, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @zachmu