Pushing AsOf expressions down to tables used in unions and subqueries in view definitions
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atements in views, since they don't automatically get included since Union is an Opaque node.
zachmu
approved these changes
Aug 5, 2022
Actually you probably want |
…queries and to recurse into subqueries' node trees to set the AsOf expression for any referenced tables.
fulghum
commented
Aug 8, 2022
fulghum
changed the title
AsOf expressions down to tables used in unions in a view definitionAsOf expressions down to tables used in unions and subqueries in view definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables used in unions and subqueries in a view definition weren't getting updated with an
asofexpression when one was used on the view. This PR extends the resolve_views analyzer rule to close those gaps.Fixes: dolthub/dolt#4011
Added Dolt enginetests, too: dolthub/dolt#4028