fix filters being dropped from prepareds on dolt_diff tables
#1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Aug 31, 2022
enginetest/memory_engine_test.go
Outdated
| @@ -84,6 +84,26 @@ func TestQueries(t *testing.T) { | |||
| // TestQueriesPrepared runs the canonical test queries against the gamut of thread, index and partition options | |||
| // with prepared statement caching enabled. | |||
| func TestQueriesPrepared(t *testing.T) { | |||
| for _, numPartitions := range numPartitionsVals { | |||
There was a problem hiding this comment.
same test time comment as other PR
enginetest/memory_engine_test.go
Outdated
| @@ -122,17 +142,17 @@ func TestSingleQuery(t *testing.T) { | |||
|
|
|||
| var test queries.QueryTest | |||
| test = queries.QueryTest{ | |||
| Query: `SELECT * FROM mytable order by i desc`, | |||
| Query: `SELECT mytable.s FROM mytable WHERE mytable.i IN (SELECT othertable.i2 FROM othertable) ORDER BY mytable.i ASC`, | |||
There was a problem hiding this comment.
same git checkout main -- enginetest/memory_engine_test.go comment as other PR
sql/type.go
Outdated
| @@ -552,6 +552,12 @@ func ConvertToBool(v interface{}) (bool, error) { | |||
| } | |||
| } | |||
|
|
|||
| // IsDeferred checks if t is Deferred | |||
| func IsDeferred(t Type) bool { | |||
There was a problem hiding this comment.
this looks unused in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformProjectionswas not transferring filters from certain prepared plans that did not contain projections.Fix for
dolt_diff_<table>dolt#3916Tests: