Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made Project() public #127

Merged
merged 2 commits into from Jun 19, 2020
Merged

made Project() public #127

merged 2 commits into from Jun 19, 2020

Conversation

andy-wm-arthur
Copy link
Contributor

No description provided.

@andy-wm-arthur
made Project() public
f3b6521 
Signed-off-by: Andy Arthur <andy@liquidata.co>
@andy-wm-arthur andy-wm-arthur mentioned this pull request Jun 18, 2020
Merged
@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review June 18, 2020 22:09
zachmu
zachmu approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sql/plan/project.go Show resolved Hide resolved
@andy-wm-arthur
pr feedback
74fa3a3 
Signed-off-by: Andy Arthur <andy@liquidata.co>
@andy-wm-arthur andy-wm-arthur merged commit afac9d3 into master Jun 19, 2020
@Hydrocharged Hydrocharged deleted the andy/public-project branch September 15, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy-wm-arthur @zachmu