Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andy/mysql validator #1279

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Andy/mysql validator #1279

merged 7 commits into from
Sep 26, 2022

Conversation

andy-wm-arthur
Copy link
Contributor

No description provided.

@andy-wm-arthur andy-wm-arthur mentioned this pull request Sep 23, 2022
Merged
Hydrocharged
Hydrocharged approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I have a few nitpicks and code suggestions but nothing major. I'm really looking forward to this, and I'll personally get a lot of mileage out of it.

server/golden/proxy.go Outdated Show resolved Hide resolved
server/golden/proxy.go Outdated Show resolved Hide resolved
server/golden/proxy.go Show resolved Hide resolved
server/golden/proxy.go Outdated Show resolved Hide resolved
server/golden/proxy.go Outdated Show resolved Hide resolved
server/golden/proxy.go Outdated Show resolved Hide resolved
server/golden/proxy.go Show resolved Hide resolved
server/golden/validator.go Show resolved Hide resolved
andy-wm-arthur and others added 2 commits September 26, 2022 09:24
@andy-wm-arthur @Hydrocharged
Update server/golden/proxy.go
9bf2e29 
Co-authored-by: Daylon Wilkins <Hydrocharged@users.noreply.github.com>
@andy-wm-arthur
pr feedback
5922bed
@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review September 26, 2022 18:59
@andy-wm-arthur andy-wm-arthur merged commit f0160ff into main Sep 26, 2022
@andy-wm-arthur andy-wm-arthur deleted the andy/mysql-validator branch September 26, 2022 18:59
@andy-wm-arthur andy-wm-arthur restored the andy/mysql-validator branch October 7, 2022 21:18
@Hydrocharged Hydrocharged deleted the andy/mysql-validator branch October 13, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy-wm-arthur @Hydrocharged