Bug fixes for CrossJoin scope visibility and disposing mem caches for IndexedInSubqueryFilter
#1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
LGTM! i was originally confused because i forgot parentRow is a concatenation of outer-scope and inner-scope dependencies, so removeParentRow, which only old removes inner-scope dependencies, is kind of a misnomer preceding your additions. But this all looks good. Thanks for cleaning up the old dispose methods also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossJoinIterwas the only join iterator that wasn't taking in aparentRowwith outer scope values and passing that row prefix to its children. There's some low-hanging fruit to refactor thejoinIters to reduce duplication, but it didn't seem high priority, so I stopped short of that. Fixes: dolthub/dolt#4926While testing that, I also hit a bug with a mem cache not being released by
IndexedInSubqueryFilterand included that fix here. There were also somedisposemember andDisposefunctions in the join iterators that I verified were not used anywhere, so I pulled those out to tidy up.Dolt CI Tests: dolthub/dolt#4947