Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqa finalize self before child recursion bug #1462

Merged
merged 3 commits into from
Dec 8, 2022
Merged

sqa finalize self before child recursion bug #1462

merged 3 commits into from
Dec 8, 2022

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Dec 8, 2022 •
edited

We must finalize a subquery [/ expression]'s scope before finalizing any child subquery [/expression]. Otherwise, the child may reference invalid parent scope indexes that are not fixed until the parent is finalized.

fulghum
fulghum approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Sorry about getting this swapped.

Would be good to update the function docs for finalizeSubqueries and finalizeSubqueriesHelper so they don't mention working through the tree from the bottom up any more.

@max-hoffman max-hoffman merged commit 1970a13 into main Dec 8, 2022
@max-hoffman max-hoffman deleted the max/recursive-sqa-finalize-parent-first branch December 8, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees

@fulghum fulghum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@max-hoffman @fulghum