Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify and fix info schema tables - 2 #1510

Merged
merged 4 commits into from Jan 5, 2023
Merged

Conversation

jennifersp
Copy link
Contributor

  • Complete tables:
    CHARACTER_SETS
    COLLATIONS
    ENGINES - only the InnoDB engine is supported
    SCHEMATA
    COLLATION_CHARACTER_SET_APPLICABILITY
  • Some info missing:
    COLUMN_STATISTICS - histogram json column only has buckets key values.
    PROCESSLIST - status is not defined completely; "Query" command is supported only.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

Probably smart to have @Hydrocharged take a quick peek at the collations.go updates, too, just in case he sees something problematic that we missed.

sql/information_schema/information_schema.go Show resolved Hide resolved
sql/collations.go Outdated Show resolved Hide resolved
sql/mysql_db/privileged_database_provider.go Show resolved Hide resolved
@jennifersp jennifersp merged commit e861f61 into main Jan 5, 2023
@jennifersp jennifersp deleted the jennifer/info-schema-tier-2 branch January 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants