Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not perform optimization_rule on like clause for utf8mb3 charset #1584

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

jennifersp
Copy link
Contributor

optimization rule uses ÿ last character in the charset utf8mb4, which does not work for utf8mb3 charset values.

@jennifersp jennifersp changed the title not perform optimization_rule on like clause for non-utf8mb4 charset not perform optimization_rule on like clause for utf8mb3 charset Feb 3, 2023
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a couple of updates

sql/analyzer/optimization_rules.go Outdated Show resolved Hide resolved
sql/analyzer/optimization_rules.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sql/analyzer/optimization_rules.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit d7e788d into main Feb 7, 2023
@jennifersp jennifersp deleted the jennifer/like-clause branch February 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants