Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ALTER EVENT statement #1754

Merged
merged 6 commits into from May 8, 2023
Merged

support ALTER EVENT statement #1754

merged 6 commits into from May 8, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented May 5, 2023 •
edited

Support for ALTER EVENT statements excluding case for moving events across databases using RENAME TO clause.
Depends on dolthub/vitess#233

@jennifersp jennifersp requested a review from fulghum May 8, 2023 17:41
@jennifersp jennifersp mentioned this pull request May 8, 2023
Merged
@jennifersp jennifersp mentioned this pull request May 8, 2023
Closed
fulghum
fulghum approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very clean code – I couldn't find much at all to comment on. Good job! ✨

sql/analyzer/load_events.go Outdated Show resolved Hide resolved
sql/plan/alter_event.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit c4ccc1f into main May 8, 2023
6 checks passed
@jennifersp jennifersp deleted the jennifer/alter-event branch May 8, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jennifersp @fulghum