Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomValidator interface #1865

Merged
merged 5 commits into from Jul 7, 2023
Merged

Add CustomValidator interface #1865

merged 5 commits into from Jul 7, 2023

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jul 5, 2023

In many places we expect to see a commit hash in our result.
Since the hashes take into account the system time when computing, it is difficult to predict what they will be.

This PR adds a new interface that can be implemented on the dolt side to check for commit hashes.

enginetest/evaluation.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@jycor jycor changed the title Add DoltCommitType to check for valid commit hashes Add CustomValidator interface Jul 7, 2023
@jycor jycor merged commit d3613a9 into main Jul 7, 2023
6 checks passed
@jycor jycor deleted the james/skip-type branch July 21, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants