have plan.EmptyTable implement sql.DeletableTable
#1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Jul 21, 2023
| @@ -85,9 +85,6 @@ func (b *BaseBuilder) buildInsertInto(ctx *sql.Context, ii *plan.InsertInto, row | |||
| func (b *BaseBuilder) buildDeleteFrom(ctx *sql.Context, n *plan.DeleteFrom, row sql.Row) (sql.RowIter, error) { | |||
| // If an empty table is passed in (potentially from a bad filter) return an empty row iter. | |||
| // Note: emptyTable could also implement sql.DetetableTable | |||
| if _, ok := n.Child.(*plan.EmptyTable); ok { | |||
There was a problem hiding this comment.
should we delete the comment?
There was a problem hiding this comment.
will delete comment.
if n.Child is an Exchange node it fails the EmptyTable check here, an alternative would be to use transform.Inspect to look for EmptyTable maybe?
There was a problem hiding this comment.
The current pattern seems fine, folding x->EmptyTable into EmptyTable is analyzer responsibility not executions
added 2 commits
July 21, 2023 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We throw an error when trying to delete from EmptyTable.
This error is partially caused by #1885
The error didn't show up in GMS as there are Exchange nodes that appear in dolt side that don't appear here.