Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Full-Text fixes #1914

Merged
merged 1 commit into from Aug 1, 2023
Merged

More Full-Text fixes #1914

merged 1 commit into from Aug 1, 2023

Conversation

Hydrocharged
Copy link
Contributor

More bugs found and fixed for FULLTEXT indexes. The ordering bug is fairly major, as it could require a drop/readd of the index, so I want to get this out now rather than waiting until I've gotten more tests/fixes in.

max-hoffman
max-hoffman approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fixes look good, how well are alter index/alter pk's tested with fulltext?

@Hydrocharged
Copy link
Contributor Author

I think I've got all of the relevant ALTER statements in a test, including dropping a used primary key, and adding a new one that becomes used.

@Hydrocharged Hydrocharged merged commit 7b82507 into main Aug 1, 2023
7 checks passed
@Hydrocharged Hydrocharged deleted the daylon/more-fulltext-fixes branch August 1, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @max-hoffman