Use EvaluateCondition for conditions in join statements #1926
Conversation
sql/rowexec/join_iters.go
Outdated
| return nil, err | ||
| } else if res == false { | ||
| } else if sql.IsFalse(res) { |
There was a problem hiding this comment.
Not sure whether this should be !sql.IsTrue like the other cases, but I've left it as IsFalse to keep to current behaviour
There was a problem hiding this comment.
This should definitely be !sql.IsTrue so that it handles null cases correctly.
If you fix that then this PR looks perfect.
adjeiv
changed the title
|
Thanks for the PR, @adjeiv! The PR looks good! I'm reviewing it right now, just to make sure that the slightly different behavior around lateral join (which you noted in your comment) is correct. |
|
@nicktobey do we know why the tests failed here? |
|
The windows tests are experiencing transient OOM issues. There was a discussion about how to fix them, I'll ask about that again. In the meantime, I don't think windows tests failing should block merges if the ubuntu and macos tests are passing. |
|
Shall we merge this then? |
Fixes dolthub/dolt#6412
Use the given EvaluateCondition util function to determine whether a join condition is satisfied, which accounts for truthy integer values as mentioned in the linked issue.