Delete old name resolution, rewrite prepared statements #1927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlparser.ParsedQuery
, whoseGenerateQuery
method converts a map of bindvars to a new query string. Caching the output of name resolution failed for manyORDER BY 1
clauses and compound expressions likeSUM(x)+1
. I don't think the better strategy is too far away, but better to not overcomplicate this right now.parse.go
tests are kept but disabled right now. I want to convert them to use the new name resolution, but the only thing I would be keeping are the query strings.Working on Dolt bump. Some parse.go helper methods are used in strange ways, and still need to get tests working.