Refactor prepards #1939
Closed
Refactor prepards #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Aug 15, 2023
| bindings = make(map[string]*querypb.BindVariable) | ||
| } | ||
| if strings.HasPrefix(name.String(), "@") { | ||
| t, val, err := ctx.GetUserVariable(ctx, strings.TrimPrefix(name.String(), "@")) |
There was a problem hiding this comment.
Is this a real use case? You can pass user var names in as bindvar arguments?
| ;`, | ||
|
|
||
| `, | ||
| //SkipPrepared: true, |
| Query: `SELECT SUBSTRING(s, 1, 10) AS sub_s, SUBSTRING(SUB_S, 2, 3) AS sub_sub_s FROM mytable`, | ||
| ExpectedErr: sql.ErrMisusedAlias, | ||
| }, | ||
| // todo: we should be case-sensitive and reject SUB_S as a valid field |
There was a problem hiding this comment.
Since when are alias names case sensitive?
There was a problem hiding this comment.
hmm yeah this is wrong, thanks for pointing out, it's fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial view of the larger name resolution PR. For review, not intended to merge.
In summary, this refactor caches saves a buffer of the original query string, with indices for bind variable replacement. Post-prepare is: 1) generate a query string with bind variables, 2) run analysis and execute.
Related vitess PR: dolthub/vitess#262