Improve IN_SUBQUERY table disambiguation #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Dec 4, 2023
| // renameExpressionTables renames table references recursively. We use | ||
| // table ids to avoid improperly renaming tables in lower scopes with the | ||
| // same name. | ||
| func renameExpressionTables(n sql.Node, rename map[sql.TableId]string) (sql.Node, transform.TreeIdentity, error) { |
There was a problem hiding this comment.
This seems fine but I'm a little confused why this should be necessary. Isn't the point of table IDs so that we can uniquely identify every table without doing string matching?
There was a problem hiding this comment.
assignExecIndexes still does string matching right now, but in general it would be nice to expand unique id use
| duplicates := make(map[string]int) | ||
| n, _, err := transform.Node(n, func(n sql.Node) (sql.Node, transform.TreeIdentity, error) { | ||
| switch n := n.(type) { | ||
| func disambiguateTables(used map[string]int, n sql.Node) (sql.Node, map[string]int, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unnesting and IN_SUBQUERY into a parent scope with a table name clash, rename the child table and update its references to the new name. Prevent EXISTS subqueries from unnesting if it doesn't full decorrelate the child scope.