Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] fix bug in memory session data management #2353

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Feb 28, 2024

Memory session table data and edit accumulators need to be kept in sync. DML edits are made to the edit accumulator and other info like auto increment are made directly through the table data reference. If not kept in sync, one of the two stomps the other.

fixes: #2349

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman merged commit 61579ae into main Feb 28, 2024
8 checks passed
@max-hoffman max-hoffman deleted the max/fix-session-ea-cache branch February 28, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foreign key constraints break auto-incrementing ids in memory mode
2 participants