Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server trace time includes parsing #2429

Merged
merged 2 commits into from
Apr 9, 2024
Merged

server trace time includes parsing #2429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b35e3c
server trace timer includes parsing
max-hoffman Apr 1, 2024
f34ca3c
Merge branch 'main' of github.com:dolthub/go-mysql-server
max-hoffman Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions server/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ func (h *Handler) doQuery(
return "", err
}

start := time.Now()

var remainder string
var prequery string
if parsed == nil {
Expand Down Expand Up @@ -394,8 +396,6 @@ func (h *Handler) doQuery(
finish := observeQuery(ctx, query)
defer finish(err)

start := time.Now()

ctx.GetLogger().Tracef("beginning execution")

// TODO: a goroutine might be worth it here, as read/writing status variables go through a mutex
Expand Down Expand Up @@ -451,7 +451,6 @@ func (h *Handler) doQuery(
}
}
}

})

pollCtx, cancelF := ctx.NewSubContext()
Expand Down