For AutoIncrement lock modes other than "interleaved", hold the lock for the duration of the insert iter. #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into a table with an unspecified auto-increment column, acquire a lock when the iterator is created, and release the lock when the iterator is closed. For the in-memory db, this is a no-op because it doesn't have a lock on generating AutoIncrement values. But Dolt has its own AutoIncrement Tracker, which will supply the lock.
nicktobey
force-pushed
the
nicktobey/autoinc
branch
from
d73e043
to
325ec52
Compare
fulghum
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the GMS side of dolthub/dolt#7634
This PR changes the engine to make it acquire a lock (provided by the storage layer) when
innodb_autoinc_lock_modeis set to the "consecutive" or "traditional" values. More specifically, it calls a new function in theAutoIncrementSetterinterface which optionally acquires a lock and returns a callback for releasing the lock.The in-memory DB doesn't have multithreading support, so when just using GMS, this is a no-op. A followup PR in Dolt will update its implementation of
AutoIncrementSetterto handle the locking.