Schema-qualified table names #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto zachmu/schemas
… case of indexed table access, some other table node types
…ndled by callers of RowCount. This means that table functions which don't have stats get treated as the default row count size by the coster
…nto zachmu/schemas
max-hoffman
approved these changes
Apr 26, 2024
It turns out that Dolt required the table to be re-resolved because of delayed foreign key resolution, which means that an update statement has the side effect of updating the serialized schema of a table :\ I fixed it in the Dolt layer. |
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes a couple unrelated issues: