Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check schema compatibility for select into #2482

Merged
merged 5 commits into from
Apr 27, 2024
Merged

don't check schema compatibility for select into #2482

merged 5 commits into from
Apr 27, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Apr 26, 2024

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comment

@@ -194,11 +194,6 @@ func wrapRowSource(ctx *sql.Context, insertSource sql.Node, destTbl sql.Table, s
}
}

err := validateRowSource(insertSource, projExprs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this method and the one it calls as well, this is the only reference

@jycor jycor merged commit 9110895 into main Apr 27, 2024
7 checks passed
@jycor jycor deleted the james/collate branch April 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot convert type longtext COLLATE utf8mb4_0900_ai_ci to datetime
2 participants