DATETIME handling & microsecond support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydrocharged
force-pushed
the
daylon/date-parse
branch
from
d1bb132
to
ba8b48a
Compare
zachmu
approved these changes
Nov 12, 2019
| // | ||
| // https://github.com/MariaDB/server/blob/mysql-5.5.36/sql-common/my_time.c#L124 | ||
| var DatetimeLayouts = []string{ | ||
| "2006-01-02", |
There was a problem hiding this comment.
I would include the main constant in this slice, then just loop over it a single time
sql/type.go
Outdated
| @@ -731,7 +743,18 @@ func (t datetimeT) Convert(v interface{}) (interface{}, error) { | |||
| case string: | |||
| t, err := time.Parse(DatetimeLayout, value) | |||
There was a problem hiding this comment.
This is a little convoluted. Better to loop over the accepted layouts a single time, returning as soon as you find one that parses.
sql/type.go
Outdated
| } | ||
|
|
||
| if failed { | ||
| return nil, ErrConvertingToTime.Wrap(err, v) |
There was a problem hiding this comment.
This wrapped error is no longer applicable (it will give the false impression that the last format attempted is the only correct one)
|
I copied the logic from the Timestamps section lol. I’ll add these adjustments there as well. |
… in parsing Signed-off-by: Daylon Wilkins <daylon@liquidata.co>
Hydrocharged
force-pushed
the
daylon/date-parse
branch
from
ba8b48a
to
c4ad10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.