Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naive/hacky show grants #301

Merged
merged 4 commits into from Feb 17, 2021
Merged

Naive/hacky show grants #301

merged 4 commits into from Feb 17, 2021

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Feb 16, 2021 •
edited

hard-coded SHOW GRANTS handling:

> dolt sql -q "show grants for current_user"
+-------------------------------------------------------------+
| Grants for root@%                                            |
+-------------------------------------------------------------+
| GRANT ALL PRIVILEGES ON *.* TO 'root'@'%' WITH GRANT OPTION |
+-------------------------------------------------------------+

@max-hoffman max-hoffman marked this pull request as ready for review February 16, 2021 18:26
zachmu
zachmu approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an engine test (just add one to queries.go).

Otherwise LGTM

sql/plan/showgrants.go Outdated
@@ -0,0 +1,71 @@
// Copyright 2020-2021 Dolthub, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should just be 2021 on copyright headers being added at this point

@max-hoffman max-hoffman merged commit dcf9697 into master Feb 17, 2021
@max-hoffman max-hoffman deleted the max/show-grants branch February 17, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@max-hoffman @zachmu