Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added proper PROCEDURE nested SELECT behavior + tests #320

Merged
merged 1 commit into from Mar 3, 2021
Merged

Added proper PROCEDURE nested SELECT behavior + tests #320

merged 1 commit into from Mar 3, 2021

Conversation

Hydrocharged
Copy link
Contributor

No description provided.

@Hydrocharged Hydrocharged requested a review from zachmu March 1, 2021 13:37
zachmu
zachmu reviewed Mar 2, 2021
View reviewed changes
enginetest/procedure_queries.go Show resolved Hide resolved
enginetest/procedure_queries.go Outdated Show resolved Hide resolved
enginetest/procedure_queries.go Outdated Show resolved Hide resolved
sql/analyzer/stored_procedures.go Outdated Show resolved Hide resolved
sql/analyzer/stored_procedures.go Outdated Show resolved Hide resolved
sql/plan/block.go Outdated Show resolved Hide resolved
sql/plan/block.go Outdated Show resolved Hide resolved
sql/plan/block.go Outdated Show resolved Hide resolved
sql/plan/block.go Outdated Show resolved Hide resolved
sql/plan/block.go Show resolved Hide resolved
zachmu
zachmu approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks very good. Excellent tests, like usual.

Not a huge fan of the new RowIter extension, it needs to justify its existence. Even after reading the code I don't have a clear idea why it's necessary.

sql/plan/if_else.go Show resolved Hide resolved
sql/plan/if_else.go Outdated Show resolved Hide resolved
sql/row.go Outdated Show resolved Hide resolved
sql/storedprocedure.go Outdated Show resolved Hide resolved
sql/storedprocedure.go Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 01d3dd8 into master Mar 3, 2021
@Hydrocharged Hydrocharged deleted the daylon/stored-procedures-3 branch March 3, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @zachmu