initial comparison and like calcs based on collation #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheni
force-pushed
the
bh/collation-changes
branch
from
1fa125f
to
254d62d
Compare
andy-wm-arthur
approved these changes
Jun 3, 2021
| @@ -65,6 +65,7 @@ func TestLike(t *testing.T) { | |||
| {"a%b", "ab", true}, | |||
| {"a%b", "a", false}, | |||
| {"a_b", "ab", false}, | |||
| {"aa:%", "AA:BB:CC:DD:EE:FF", true}, | |||
There was a problem hiding this comment.
this test could be simpler, why not
{"aa:%", "AA:BB", true},
There was a problem hiding this comment.
no reason. Was using a valid MAC address format like what we see in the nautobot code.
| var CollationToMySQLVals = map[string]mysqlCollationRow{ | ||
| Collation_binary.Name: {63, Y, Y, 0, NoPad}, | ||
| Collation_utf8_general_ci.Name: {33, Y, Y, 1, PadSpace}, | ||
| Collation_utf8mb4_0900_ai_ci.Name: {255, Y, Y, 0, NoPad}, |
There was a problem hiding this comment.
I think this is fine for now, given the size of the change already. I think we want CollationToMySQLVals and characterSetMaxLengths, etc. to be inlined into the Collation struct
There was a problem hiding this comment.
Yeah, true. Not exactly sure what I want to do with the collations structure / interface, but I'll go back and take a second look soon and figure out what to do about case sensitivity in where clauses which is busted atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the LIKE operator always does a case sensitive match. This should be based on the collation. This puts initial support in for doing per collation comparison and like calculations. Currently the comparison changes are disabled as the codebase uses the compare function for more than just WHERE clause calculations which sometimes need to be case sensitive.