Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vinai/create table select #449

Merged
merged 24 commits into from Jun 11, 2021
Merged

Vinai/create table select #449

merged 24 commits into from Jun 11, 2021

Conversation

VinaiRachakonda
Copy link
Contributor

@VinaiRachakonda VinaiRachakonda commented Jun 4, 2021 •
edited

This PR Support CREATE TABLE SELECT AS syntax as well an interface for copying tables.

  1. It does not support more sophisticated queries such as CREATE TABLE mytable(pk int) AS SELECT.... That is tables with their own schemas are not interpreted due to parsing limitations.

@VinaiRachakonda VinaiRachakonda changed the title [wip] Vinai/create table select Vinai/create table select Jun 5, 2021
Hydrocharged
Hydrocharged approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any glaring issues. Go ahead and merge this, and I'll give a more in-depth review later.

@VinaiRachakonda VinaiRachakonda merged commit 1a756a7 into master Jun 11, 2021
@Hydrocharged Hydrocharged deleted the vinai/create-table-select branch December 8, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VinaiRachakonda @Hydrocharged