Fix JSON string comparison. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix when a JSON is compared with a string, and apply unquote as MySQL does. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
| @@ -272,7 +273,15 @@ func (t stringType) Convert(v interface{}) (interface{}, error) { | |||
| return "", nil | |||
| } | |||
|
|
|||
| return s.ToString(nil) | |||
| str, err := s.ToString(nil) | |||
There was a problem hiding this comment.
Should this case be handling all JSONValues, not just JSONDocuments?
There was a problem hiding this comment.
I just leave as it was, but makes sense. If we use JSONValue then we need to remove the following piece of code:
if s.Val == nil {
return "", nil
}tests still pass without it.
There was a problem hiding this comment.
If we don't handle arbitrary JSONValues somehow in this function then JSONValues that aren't JSONDocuments won't be supported, right? Are users supposed to be able to use their own implementations of JSONValue?
There was a problem hiding this comment.
Changed! Also, it fixes another bug related to JSON null values. They were translated to "" instead of "null"
It also uncovered other bug related with null JSONValues. They were translated to "" instead of "null". Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
zachmu
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix when a JSON is compared with a string, and apply
unquote as MySQL does.
Fixes #474
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com