Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in alias resolution for aliases defined in group by and used in order by #501

Merged
merged 6 commits into from Jul 29, 2021

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jul 14, 2021

This fixes #499

@zachmu zachmu requested a review from Hydrocharged July 14, 2021 22:11
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1100,6 +1100,33 @@ var ScriptTests = []ScriptTest{
},
},
},
{
Name: "Issue #499",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tripped me up at first as I was getting different results when trying this locally on MySQL. I forgot that it interprets the given time on insertion as your local timezone, so setting my instance to UTC fixed it lol.

@zachmu zachmu merged commit 15a9bee into master Jul 29, 2021
@Hydrocharged Hydrocharged deleted the zachmu/alias-bug branch December 8, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ORDER BY" expressions behaviour compatible with MySQL?
2 participants