Added an extension point for custom function providers #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
force-pushed
the
zachmu/catalog-refactor
branch
from
b4fc5e1
to
1c9fb6c
Compare
andy-wm-arthur
approved these changes
Sep 24, 2021
driver/conn.go
Outdated
| @@ -23,17 +23,14 @@ import ( | |||
|
|
|||
| // Conn is a connection to a database. | |||
| type Conn struct { | |||
| options Options | |||
| options *Options | |||
| catalog *catalog | |||
There was a problem hiding this comment.
while you're here, type catalog on line 155 would benefit from having a new name
| return func(ctx *sql.Context, e ...sql.Expression) (sql.Expression, error) { | ||
| return NewPad(ctx, pType, e...) | ||
| } | ||
| func NewLeftPad(ctx *sql.Context, e ...sql.Expression) (sql.Expression, error) { |
There was a problem hiding this comment.
don't break the internet Zach
There was a problem hiding this comment.
Don't ever tell me how to live my life
Yeah, I think we're moving in that direction. If anything, the Catalog concept is a caching layer for the analyzer, not a public interface. Just didn't want to go quite that far in one push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, embarked on a major refactor: