Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip fk validation on CREATE TABLE when fks are disabled #581

Merged
merged 2 commits into from Oct 12, 2021
Merged

Skip fk validation on CREATE TABLE when fks are disabled #581

merged 2 commits into from Oct 12, 2021

Conversation

Hydrocharged
Copy link
Contributor

No description provided.

zachmu
zachmu approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zachmu
zachmu approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an engine test though

@Hydrocharged Hydrocharged merged commit 1303cba into main Oct 12, 2021
@Hydrocharged Hydrocharged deleted the daylon/delayed-fk branch October 12, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @zachmu