Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced a ViewProvider extension #591

Merged
merged 21 commits into from Oct 18, 2021
Merged

Introduced a ViewProvider extension #591

merged 21 commits into from Oct 18, 2021

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Oct 15, 2021

As part of this, got rid of the IndexRegistry and ViewRegistry on the context, put them on the Session instead. These changes significantly simplify the process of constructing an engine and running queries.

@zachmu zachmu requested a review from reltuk October 15, 2021 20:38
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmu zachmu merged commit a969820 into main Oct 18, 2021
@Hydrocharged Hydrocharged deleted the zachmu/views branch December 8, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants