Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/plan: Fix join iterators to always Close() their secondary RowIter. Fix Subquery to Dispose its subquery. #594

Merged
merged 2 commits into from Oct 20, 2021
Merged

sql/plan: Fix join iterators to always Close() their secondary RowIter. Fix Subquery to Dispose its subquery. #594

merged 2 commits into from Oct 20, 2021

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Oct 19, 2021

No description provided.

zachmu
zachmu approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmu zachmu merged commit 400af43 into main Oct 20, 2021
@Hydrocharged Hydrocharged deleted the aaron/join-iter-memory-leak branch December 8, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reltuk @zachmu