Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced index range complexity, removed range overlapping #609

Merged
merged 1 commit into from Nov 13, 2021

Conversation

Hydrocharged
Copy link
Contributor

All Ranges now only have a single column expression per range. Ranges no longer overlap. Additional comment changes and whatnot to facilitate both of these changes.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new interface, agree it's better. Just some comments about names and clarity

sql/index_builder.go Show resolved Hide resolved
sql/range.go Outdated Show resolved Hide resolved
sql/range.go Outdated Show resolved Hide resolved
sql/range.go Show resolved Hide resolved
sql/range_column_expr.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine index lookups on different columns of multi-column indexes with different operators
2 participants