Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zachmu/datemath #67

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Zachmu/datemath #67

merged 3 commits into from
Feb 19, 2020

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Feb 19, 2020

Fixed panic when using interval expressions in WHERE clauses.

@zachmu
Engine test for date_sub bug
a379fac 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Fixed panic for date_sub, date_add in where clause.
a018e75 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu zachmu requested a review from reltuk February 19, 2020 18:57
reltuk
reltuk reviewed Feb 19, 2020
View reviewed changes
engine_test.go Outdated Show resolved Hide resolved
reltuk
reltuk approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couple nits.

@zachmu
PR feedback
da38e1f 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Copy link
Member Author

zachmu commented Feb 19, 2020

Fixed panic when using interval expressions in WHERE clauses.

@zachmu zachmu merged commit df3a768 into ld-master Feb 19, 2020
@Hydrocharged Hydrocharged deleted the zachmu/datemath branch April 23, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zachmu @reltuk